[Port dspace-8_x] Edit bitstream page refactor#4103
Open
AAwouters wants to merge 17 commits intoDSpace:dspace-8_xfrom
Open
[Port dspace-8_x] Edit bitstream page refactor#4103AAwouters wants to merge 17 commits intoDSpace:dspace-8_xfrom
AAwouters wants to merge 17 commits intoDSpace:dspace-8_xfrom
Conversation
- Introduced 'setFields' method - Applied more consistency in using fields vs parameters in methods - Split up methods related to iiif
Splitting the creation of the form into multiple methods that do one specific thing (e.g. updating the form model, creating the form group, prefilling data in the form, ...) allows for easier theming of the form itself.
Without this fix the form showed old data when immediately going back to the edit page after changing the primary bitstream or format.
Moved the creation of the update observables to their own methods and unified the handling of their results in a single subscription
# Conflicts: # src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.html # src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.spec.ts # src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.ts
tdonohue
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dspace-8_x port of #4102